Stranger's pull request fixed a bug via the wrong code — the real fix was accidental
A developer received an unsolicited pull request fixing a real bug in their Safari MCP server, with clean code and passing CI tests. Only when writing up the change did the author discover that the two code hunks the contributor highlighted as the fix were behaviorally identical to what they replaced. The actual bug was closed by a third, unemphasized change that neither party had focused on. The underlying issue involved a positional request-response queue over stdin/stdout that could fall permanently out of sync if a write failure left an armed callback consuming a future reply. A missing assignment in the catch block meant one broken-pipe error was enough to cascade into indefinite hangs for all subsequent helper calls.
This is an AI-generated summary. ShortSingh links to the original source for the complete article.
Discussion (0)
Log in to join the discussion and vote.
Log in