Developer Fixes Null Check Bug in Hermes Agent That Crashed Permission System
A full-stack developer from Kolkata, Aniruddha Adak, identified and fixed a critical bug in NousResearch's open-source hermes-agent framework. The flaw resided in the permission bridge, where the function request_permission could silently return None when an ACP client sent an empty response, causing an AttributeError crash instead of a safe denial. Because the existing code accessed result.decision without first checking for None, the agent would crash mid-session rather than defaulting to a secure deny state. Adak reproduced the issue locally, then submitted a minimal patch adding a guard clause that returns 'deny' immediately whenever the response is None. The fix, merged as PR #13457, follows a standard fail-safe security pattern and includes a dedicated unit test to prevent regression.
This is an AI-generated summary. ShortSingh links to the original source for the complete article.
Discussion (0)
Log in to join the discussion and vote.
Log in